-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token allocation chart #914
Conversation
Visit the preview URL for this PR (updated for commit 10b117d): https://astar-apps--pr914-feat-token-chart-g9s5kgen.web.app (expires Thu, 14 Sep 2023 12:16:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
Yes, I am aware of that, but the issue happens because I am missing data for some token allocations. In reality, we have the following situation I can add one more section to the chart for this unknown allocations, but not sure how to call it |
so 15% must be the tokens on the market, so please use blue gradients that is very clear for people to see one in circulation, and the other is not. Thats why I wanted to use the word "locked" for Not Circulating supply instead of Other, so we can use the Other for some tokens that is in the wallets. Let me confirm the name with Maarten once the chart allocation is fixed. |
Bobo, sorry, I was not looking at the Light theme. Could you change the Other colour in the chart from Navy to Grey001 F7F7F8. It might be too light but I could not check the change in the inspect🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it works.
* Initial chart implementation * Chart control styling and improvements * Light theme support * Styling improvement * Translations * Added 4th segment * Code review updates * Don't display 0 values * e2e test engine improvements * Test fixes * XCM003 fix * Improved Metamask tests
Pull Request Summary
Check list
This pull request makes the following changes:
Adds
Fixes
Changes
To-dos