Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated withdrawal UI #909

Merged
merged 9 commits into from
Aug 24, 2023
Merged

fix: updated withdrawal UI #909

merged 9 commits into from
Aug 24, 2023

Conversation

impelcrypto
Copy link
Member

@impelcrypto impelcrypto commented Aug 22, 2023 •
edited
Loading

Pull Request Summary

  • fix: updated withdrawal UI
  • fix: removed IS_APPLIED_RANDOM_ENDPOINT from local storage

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Changes

  • fix: updated withdrawal UI
    • if the resulting staking amount is lower than minimum staking amount:
      • display a warning message
      • unstake all of staked balance

Screenshot 2023-08-22 at 4 00 12 PM

@github-actions
Copy link

github-actions bot commented Aug 22, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit e8e228a):

https://astar-apps--pr909-fix-update-withdrawa-k9umad9q.web.app

(expires Thu, 31 Aug 2023 11:03:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@impelcrypto impelcrypto requested review from bobo-k2 and gluneau August 23, 2023 14:00
@impelcrypto impelcrypto marked this pull request as ready for review August 23, 2023 14:00
bobo-k2
bobo-k2 requested changes Aug 23, 2023
View reviewed changes
tests/common-api.ts Outdated Show resolved Hide resolved
bobo-k2
bobo-k2 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@bobo-k2 bobo-k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gluneau
gluneau approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@gluneau gluneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, all tests in dappstaking-transactions.spec.ts passed!

@impelcrypto impelcrypto merged commit 7b005b8 into main Aug 24, 2023
@impelcrypto impelcrypto deleted the fix/update-withdrawal-ui branch August 24, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobo-k2 bobo-k2 bobo-k2 approved these changes

@gluneau gluneau gluneau approved these changes

@ayumitk ayumitk Awaiting requested review from ayumitk

@Kahonnohak Kahonnohak Awaiting requested review from Kahonnohak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@impelcrypto @gluneau @bobo-k2