Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added 'network statuses' section on dashboard page #886

Merged
merged 17 commits into from
Aug 8, 2023

Conversation

impelcrypto
Copy link
Member

@impelcrypto impelcrypto commented Jul 31, 2023

Pull Request Summary

  • feat: added 'network statuses' and 'Collator' section on dashboard page

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

Adds

  • feat: added 'network statuses' and 'Collator' section on dashboard page

  • fix: removed version information on the network button
    image

  • Added tooltip when the XCM deposit/withdrawal is disabled (this tooltip can be viewed in production page)

Screenshot 2023-08-07 at 4 40 05 PM

@github-actions
Copy link

github-actions bot commented Jul 31, 2023

Visit the preview URL for this PR (updated for commit 7044a6a):

https://astar-apps--pr886-feat-network-status-t388p25s.web.app

(expires Tue, 15 Aug 2023 04:37:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@impelcrypto impelcrypto marked this pull request as ready for review August 7, 2023 09:26
@impelcrypto impelcrypto changed the title feat: added 'network status' section on dashboard page feat: added 'network statuses' section on dashboard page Aug 7, 2023
Copy link
Contributor

@gluneau gluneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and the preview works as intended.

@Kahonnohak
Copy link
Contributor

Nice work! Two things

  • Could you make the text size of the update xx sec ago, 12px please?
  • The icon next to collator numbers, could you put it in the centre (of the height) the screenshots are after I have adjusted.
Screenshot 2023-08-07 at 22 19 01 Screenshot 2023-08-07 at 22 19 15

@impelcrypto
Copy link
Member Author

@Kahonnohak Updated!

Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@impelcrypto impelcrypto merged commit 281cabd into main Aug 8, 2023
@impelcrypto impelcrypto deleted the feat/network-status branch August 8, 2023 06:47
gluneau added a commit that referenced this pull request Aug 8, 2023
* wip: Network status

* styles: finished basing styling

* styles: finished basing styling (2)

* feat: added logic

* feat: updated logic

* feat: added tooltip on transfer page

* feat: added collator UI

* fix: clean up

* feat: added test

* feat: added test (2)

* fix: removed version information on the network button

* fix: removed version information on the network button (2)

* refactor: clean up

* fix: links

* fix: added comments

* fix: styling

Co-authored-by: impelcrypto <92044428+impelcrypto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants