Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for unstaking max amount #1421

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Fix for unstaking max amount #1421

merged 4 commits into from
Dec 20, 2024

Conversation

bobo-k2
Copy link
Contributor

@bobo-k2 bobo-k2 commented Nov 30, 2024

Pull Request Summary

In some edge cases stakers weren't able to un-stake max amount

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

gtg7784 and others added 3 commits November 15, 2024 18:59
* Inflation chart fix

* Current inflation calculation and cleanup

* Minor bug fixes

* Division by zero fix
Copy link

github-actions bot commented Nov 30, 2024

Visit the preview URL for this PR (updated for commit ab16f70):

https://astar-apps--pr1421-fix-unstake-max-cjndvlx7.web.app

(expires Wed, 25 Dec 2024 16:42:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

Base automatically changed from release-hotfix to main December 2, 2024 15:15
@bobo-k2 bobo-k2 changed the base branch from main to release-hotfix December 18, 2024 16:33
@bobo-k2 bobo-k2 marked this pull request as ready for review December 19, 2024 10:00
@bobo-k2 bobo-k2 merged commit 9430ca6 into release-hotfix Dec 20, 2024
5 of 6 checks passed
@bobo-k2 bobo-k2 deleted the fix/unstake-max branch December 20, 2024 09:41
impelcrypto added a commit that referenced this pull request Jan 13, 2025
* remove lfgm (#1426)

* Feature/replace lfgm (#1428)

* update link

* add surge gif

* update mobile

* update desktop

* fix mobile style

* add tooltip

* update image

* fix merge errors

* Fix for unstaking max amount (#1421)

* update polkadot chain icon (#1415)

* Inflation chart fix (#1417)

* Inflation chart fix

* Current inflation calculation and cleanup

* Minor bug fixes

* Division by zero fix

* Fix for unstaking max amount

* Better handling unstake warning messages

---------

Co-authored-by: Taegeon Alan Go <tae.gun7784@gmail.com>

* Feature/remove deprecated networks (#1430)

* remove zKyoto from bridges

* remove zKyoto from network selection

* remove zKatana code

* fix hover styles

* restore native bridge

* remove zKyoto refs

* Account NFT loading fix (#1434)

* Account NFT loading fix

* Comment out NFT fetching

* Don't offer rewards re-staking if staking is not possible (#1436)

* Re-stake in last era fix

* Can restake check fix

* Disable deposit to zkEVM (#1433)

* Disable deposit to zkEVM

* Disable deposit to zk when connected to L1

* Disabled info message update

* fix: redirect to assets page after changing the network (#1435)

---------

Co-authored-by: Roy <92044428+impelcrypto@users.noreply.github.com>

* Bridge page reorganization (#1437)

* Bridge page reorganization

* Input placeholder color update

---------

Co-authored-by: Taegeon Alan Go <tae.gun7784@gmail.com>
Co-authored-by: Saša Pul <4625220+codespool@users.noreply.github.com>
Co-authored-by: Roy <92044428+impelcrypto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants