-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix recent history link for zkevm #1312
Conversation
Visit the preview URL for this PR (updated for commit 65d2f6d): https://astar-apps--pr1312-fix-recent-history-z-2yxdrok4.web.app (expires Wed, 19 Jun 2024 03:37:22 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gtg7784 Thanks for fixing! I think we don't need to createcastZkEVMTransferHistory
and castZkEVMTransferHistory
function, just use blockcsout
URL if Number(networkIdx) === endpointKey.ASTAR_ZKEVM || Number(networkIdx) === endpointKey.ZKYOTO
in castTransferHistory
function.
Thanks roy, resolved with 65d2f6d commit |
* Ledger dApp Staking V3 Promotion Card (#1304) * Ledger dApp Staking v3 promotion card to dApp Staking page - Add Ledger dApp Staking v3 banner to image folder - Update dapp_promtions.json file * Update dapp_promotions.json * Update dapp_promotions.json * Update dapp_promotions.json * dApp staking banner text update (#1308) * dApp staking banner text update * Banner text update * Improve getDapp method error handling (#1307) * fix recent history link for zkevm (#1312) * fix recent history link for zkevm * remove useless console.log * remove XCM txs in getZkEVMTxHistories function * refactor castTransferHistory function * hotfix: disabling xcm for Shiden (#1313) --------- Co-authored-by: Gaius_sama <85451570+Gunit2481@users.noreply.github.com> Co-authored-by: Taegeon Alan Go <tae.gun7784@gmail.com> Co-authored-by: Roy <92044428+impelcrypto@users.noreply.github.com>
Pull Request Summary
Check list
This pull request makes the following changes:
Adds
modules/information/recent-history/index.ts
modules/information/recent-history/index.ts
Fixes
components/assets/transfer/Information.vue