Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix recent history link for zkevm #1312

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Conversation

gtg7784
Copy link
Member

@gtg7784 gtg7784 commented Jun 11, 2024

Pull Request Summary

in the transaction page, link of recent history using Astar zkEVM is linked to subscan, I separate the logic of aggregate transaction history

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Adds

  • castZkEVMTransferHistory function in modules/information/recent-history/index.ts
  • getZkEVMTxHistories function in modules/information/recent-history/index.ts

Fixes

  • separate aggregate tx histories logic for zkEVM in setTxHistories function at components/assets/transfer/Information.vue

@gtg7784 gtg7784 requested review from bobo-k2 and impelcrypto June 11, 2024 16:35
@gtg7784 gtg7784 changed the base branch from main to release-hotfix June 11, 2024 16:36
Copy link

github-actions bot commented Jun 11, 2024

Visit the preview URL for this PR (updated for commit 65d2f6d):

https://astar-apps--pr1312-fix-recent-history-z-2yxdrok4.web.app

(expires Wed, 19 Jun 2024 03:37:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

Copy link
Member

@impelcrypto impelcrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gtg7784 Thanks for fixing! I think we don't need to createcastZkEVMTransferHistory and castZkEVMTransferHistory function, just use blockcsout URL if Number(networkIdx) === endpointKey.ASTAR_ZKEVM || Number(networkIdx) === endpointKey.ZKYOTO in castTransferHistory function.

image

@gtg7784
Copy link
Member Author

gtg7784 commented Jun 12, 2024

@gtg7784 Thanks for fixing! I think we don't need to createcastZkEVMTransferHistory and castZkEVMTransferHistory function, just use blockcsout URL if Number(networkIdx) === endpointKey.ASTAR_ZKEVM || Number(networkIdx) === endpointKey.ZKYOTO in castTransferHistory function.

image

Thanks roy, resolved with 65d2f6d commit

@gtg7784 gtg7784 requested a review from impelcrypto June 12, 2024 03:31
@gtg7784 gtg7784 merged commit c784228 into release-hotfix Jun 12, 2024
5 of 6 checks passed
@gtg7784 gtg7784 deleted the fix/recent-history-zk branch June 12, 2024 10:12
bobo-k2 added a commit that referenced this pull request Jun 13, 2024
* Ledger dApp Staking V3 Promotion Card  (#1304)

* Ledger dApp Staking v3 promotion card to dApp Staking page

- Add Ledger dApp Staking v3 banner to image folder
- Update dapp_promtions.json file

* Update dapp_promotions.json

* Update dapp_promotions.json

* Update dapp_promotions.json

* dApp staking banner text update (#1308)

* dApp staking banner text update

* Banner text update

* Improve getDapp method error handling (#1307)

* fix recent history link for zkevm (#1312)

* fix recent history link for zkevm

* remove useless console.log

* remove XCM txs in getZkEVMTxHistories function

* refactor castTransferHistory function

* hotfix: disabling xcm for Shiden (#1313)

---------

Co-authored-by: Gaius_sama <85451570+Gunit2481@users.noreply.github.com>
Co-authored-by: Taegeon Alan Go <tae.gun7784@gmail.com>
Co-authored-by: Roy <92044428+impelcrypto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants