Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Total Tokens to be Burned to Our Data tab #1205

Merged
merged 10 commits into from
Mar 2, 2024

Conversation

gluneau
Copy link
Contributor

@gluneau gluneau commented Feb 27, 2024

Pull Request Summary

  • Add tokens to be burned by empty slot
  • Add Percentage to be burned to tier card title
  • Add Total Tokens to be Burned to Our Data tab

image

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

Copy link

github-actions bot commented Feb 27, 2024

Visit the preview URL for this PR (updated for commit 48753d9):

https://astar-apps--pr1205-feat-dapps-unminted-yf2amc1d.web.app

(expires Fri, 08 Mar 2024 14:39:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@gluneau gluneau requested a review from bobo-k2 February 27, 2024 22:28
@gluneau gluneau changed the title feat: Add tokens to be burned by empty slot feat: Add Percentage to be burned to tier card title Feb 27, 2024
@gluneau gluneau changed the title feat: Add Percentage to be burned to tier card title feat: Add Total Tokens to be Burned to Our Data tab Feb 28, 2024
@Kahonnohak
Copy link
Contributor

Thanks lets try to add this to the release!

Copy link
Contributor

@bobo-k2 bobo-k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what was idea behind this PR, but it is not possible calculate tokens to be burned, because tiers allocations are not fixed. If the goal was to have a rough estimation than ok.

src/staking-v3/hooks/useDappStaking.ts Outdated Show resolved Hide resolved
src/staking-v3/components/data/DataList.vue Outdated Show resolved Hide resolved
src/staking-v3/components/data/DataList.vue Outdated Show resolved Hide resolved
src/staking-v3/components/data/DataList.vue Outdated Show resolved Hide resolved
src/staking-v3/components/data/DataList.vue Outdated Show resolved Hide resolved
src/staking-v3/components/data/DataList.vue Outdated Show resolved Hide resolved
@gluneau
Copy link
Contributor Author

gluneau commented Feb 29, 2024

I've also updated the description wording to include the word Estimated

@gluneau gluneau requested a review from bobo-k2 February 29, 2024 17:03
Copy link
Contributor

@bobo-k2 bobo-k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -51,10 +52,28 @@ export function useDataCalculations() {
() => store.getters['stakingV3/getNumberOfStakersAndLockers']
);

const { leaderBoards } = useLeaderboard();

const tokensToBeBurned = computed(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const tokensToBeBurned = computed(() => {
const tokensToBeBurned = computed<string>(() => {

@impelcrypto impelcrypto requested a review from Kahonnohak March 1, 2024 18:13
@Kahonnohak Kahonnohak merged commit 2ca65d1 into main Mar 2, 2024
8 of 9 checks passed
@Kahonnohak Kahonnohak deleted the feat/dapps-unminted branch March 2, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants