-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Total Tokens to be Burned to Our Data tab #1205
Conversation
Visit the preview URL for this PR (updated for commit 48753d9): https://astar-apps--pr1205-feat-dapps-unminted-yf2amc1d.web.app (expires Fri, 08 Mar 2024 14:39:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
Thanks lets try to add this to the release! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what was idea behind this PR, but it is not possible calculate tokens to be burned, because tiers allocations are not fixed. If the goal was to have a rough estimation than ok.
I've also updated the description wording to include the word |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -51,10 +52,28 @@ export function useDataCalculations() { | |||
() => store.getters['stakingV3/getNumberOfStakersAndLockers'] | |||
); | |||
|
|||
const { leaderBoards } = useLeaderboard(); | |||
|
|||
const tokensToBeBurned = computed(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const tokensToBeBurned = computed(() => { | |
const tokensToBeBurned = computed<string>(() => { |
Pull Request Summary
Add tokens to be burned by empty slotAdd Percentage to be burned to tier card titleCheck list