fix: enables Wallet Connect #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit c04d4c6): https://astar-apps--pr1187-fix-enable-wallet-co-s898qj6k.web.app (expires Wed, 21 Feb 2024 05:01:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
bobo-k2
approved these changes
Feb 14, 2024
|
I was on desktop and had this QR code and accessed from my mobile, after I press the button on Mobile it allowed desktop to connect to it as well, is that expected? |
gluneau
approved these changes
Feb 14, 2024
@Kahonnohak I can't find what you're worried about. Could you show me with some screenshots if you have concerns? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Check list
This pull request makes the following changes:
Changes