Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text ellipsis to the dApp cards #1186

Merged
merged 7 commits into from
Feb 14, 2024

Conversation

ayumitk
Copy link
Contributor

@ayumitk ayumitk commented Feb 13, 2024

Pull Request Summary

  • Added text ellipsis to the dApp cards:
    • dApp title -> 1 line
    • dApp description -> 3 lines
Screenshot 2024-02-13 at 11 32 08 AM
  • Fixed the arrow style of the ads section
Screenshot 2024-02-13 at 11 35 04 AM
  • Fixed the unwanted space of the dApp builders.
Screenshot 2024-02-13 at 11 40 05 AM

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

Copy link

github-actions bot commented Feb 13, 2024

Visit the preview URL for this PR (updated for commit e45a783):

https://astar-apps--pr1186-fix-dapp-card-text-e-77ofd4zj.web.app

(expires Tue, 20 Feb 2024 20:57:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

This reverts commit 29c7d3f.
@ayumitk ayumitk changed the base branch from main to release-hotfix February 13, 2024 18:58
@Kahonnohak
Copy link
Contributor

ow I see dApp title - we might have to re-consider not to hide the dApp name but thank you!

Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayumitk ayumitk merged commit 378bee2 into release-hotfix Feb 14, 2024
5 of 6 checks passed
@ayumitk ayumitk deleted the fix/dapp-card-text-ellipsis branch February 14, 2024 05:50
impelcrypto pushed a commit that referenced this pull request Feb 16, 2024
* Enable dApp staking v3 on Astar (#1182)

* Add text ellipsis to the dApp cards (#1186)

* add text ellipsis to the dapp card

* update

* Revert "update"

This reverts commit 29c7d3f.

* fix the arrow style of the ads section

* fix builders card layout

* fix dapp page short description

* Don't batch a single call (#1184)

* Don't batch a single call

* Ubstoppable grants background

* Min staking amount warning condition fix

* Code review update

* Category title padding fix

* Fix for min staking amount warning (#1191)

---------

Co-authored-by: Ayumi Takahashi <ayumee528@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants