Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update v3 styles #1150

Merged
merged 35 commits into from
Jan 30, 2024
Merged

Update v3 styles #1150

merged 35 commits into from
Jan 30, 2024

Conversation

ayumitk
Copy link
Contributor

@ayumitk ayumitk commented Jan 24, 2024 •
edited
Loading

Pull Request Summary

Top page

  • Build&Earn hero (general)
  • add grid background
  • add dApps list slide arrows
  • add dApps list card hover style
    • add icon for staking number
    • add icon for staking amount
      • move svg icon to Logo component
    • format amount
  • organize data list
  • animation (P2) - @ayumitk will create another PR for it
  • adjust the leaderboard title position for wide screen
  • adjust padding under the status
  • text animation

Project page

  • add grid background
  • format total staked balance
  • remove flip animation if no description
  • make icon blur background image smaller
    • adjust icon background position for mobile screen
  • add close button to the fullscreen dApp image (P2)
  • use the same carousel style to the dApp images (P2)

Owner page

  • add grid background
  • adjust padding under the dApp header

Assets page

  • move register now banner to the assets page (P2)
  • modal title change from unbond to unlock

Common

  • make titles Italic and ticker
  • change text from unbond to unlock

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Adds

  • (ex: Add feature A)

Fixes

  • (ex: Fix validation function)

Changes

  • (ex: Change document B)

To-dos

*Feel free to remove this section if it's not applicable

  • (ex: add user list)

@ayumitk ayumitk mentioned this pull request Jan 24, 2024
Merged
6 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 42b64fe):

https://astar-apps--pr1150-feat-update-v3-styli-5zmvyr7q.web.app

(expires Tue, 06 Feb 2024 17:50:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@ayumitk
Copy link
Contributor Author

ayumitk commented Jan 25, 2024

Hi @Kahonnohak, please take a look when you have time.
In this PR, I've changed the dApp card border colour to gray-2 on the top page for the experiment. I feel the gray-2 is a bit pale. Should we go maybe gray-3 or back to navy-1? What do you think?

Screenshot 2024-01-24 at 12 52 16 PM

@Kahonnohak
Copy link
Contributor

Thank you, yes Navy is probably better isn't it. Just realised we would have to go over other pages and may need to change other places too. Lets not. Thanks for checking

@ayumitk ayumitk marked this pull request as ready for review January 29, 2024 07:40
Kahonnohak
Kahonnohak approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

impelcrypto
impelcrypto approved these changes Jan 30, 2024
View reviewed changes
src/components/assets/Account.vue Outdated
@@ -275,6 +276,8 @@ export default defineComponent({

const currentNetworkName = ref<string>(providerEndpoints[currentNetworkIdx.value].displayName);

const { isDappStakingV3 } = useDappStaking();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this if you are not using at this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@impelcrypto oh, this again. thank you. I've removed it in e02e1de

src/components/common/Logo.vue
@@ -1,11 +1,36 @@
<template>
<img src="~assets/img/astar_logo_v2.svg" class="icon--logo" />
<svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add this to Astar UI in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@impelcrypto Agree! Let me add this to my task list after dApp staking v3

@ayumitk ayumitk merged commit 40f3912 into main Jan 30, 2024
6 of 7 checks passed
@ayumitk ayumitk deleted the feat/update-v3-styling-and-wording branch January 30, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobo-k2 bobo-k2 bobo-k2 approved these changes

@Kahonnohak Kahonnohak Kahonnohak approved these changes

@impelcrypto impelcrypto impelcrypto approved these changes

@gluneau gluneau Awaiting requested review from gluneau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ayumitk @Kahonnohak @bobo-k2 @impelcrypto