-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various improvements #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's more modular now and has a slightly easier to follow flow. `$serverInstance` is mutable and changes throughout the bootup sequence as more parts are added. $ratchetServer is always an instance of the class used at the outset.
Let's start pushing people forwards
As this package relies on my fork of that package, it's better to bundle it and expose via this package.
Remove pelim/laravel-zmq again. Cut back all of Laravel to just what we actually use in *this* package that isn't provided elsewhere
gcphost
approved these changes
Nov 14, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Will, as you can probably tell from this PR I've been going around with this package for a bit. I'd really like to just push forward with one package rather than publicise my fork.
I appreciate this may seem like a daunting PR to review. Happy to work through it with you, but the main changes are:
You'll probably notice references to
laravel-zmq
- please ignore all of this, I've since removed it.Final note is that this all is most definitely a breaking change that will stop backwards compatibility. So I recommend that you tag a new major release if you merge these changes.
Any issues or questions, let me know and I will try to resolve.