-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem in ThemeManager Test for Theme backend edition #451
Comments
+1 |
zoltiecodes
added a commit
to zoltiecodes/Platform
that referenced
this issue
Feb 2, 2018
Fix Issue AsgardCms#451
Merged
Fixed and tagged in 3.5.1 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary of issue
In Modules\Workshop\Manager\StylistThemeManager.php - line 45
foreach ($this->getDirectories() as $directory) { if (! str_contains(strtolower($directory), strtolower($themeName))) { continue; } return $this->getThemeInfoForPath($directory); }
This is too generalist, if le path of project include the theme name, all directories of themes will contain the theme name and first theme will be returned
Can you test only last member of path ?
Steps to reproduce
Create a theme in a path with the theme name.
Sample : /home/www/society-fr/web/Themes/Society
The text was updated successfully, but these errors were encountered: