Fix Gun Message Leaks #659
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humaite
force-pushed
the
humaite/717-unhandled-message-in-blacklist
branch
2 times, most recently
from
efea96e to
e7042b4
Compare
ar_http client was using internal functions from inet (`inet:start_timer/1` and `inet:stop_timer/1`). Those functions are wrapper around `timer` module and send a message to the current active process doing the http request. Unfortunately, this is not compatible with gun:await/3 function and breaks its loop. Gun messages are after send to the active process. This commit also enforce request cancellation when something goes wrong (error/timeout) to avoid leaking messages coming in the current process.
humaite
force-pushed
the
humaite/717-unhandled-message-in-blacklist
branch
from
e7042b4 to
33b2be2
Compare
|
After more than 10 hours running on a test server, this patch looks okay. No leaks reported by logs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ar_httpclient was using internal functionsfrom inet (
inet:start_timer/1andinet:stop_timer/1). Those functions are wrapper aroundtimermodule and send a message to the current active process doing the http request. Unfortunately, this is not compatible with `gun:await/3è function and breaks its loop. Gun messages are after send to the active process.see: https://github.com/ArweaveTeam/arweave-dev/issues/717