Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Profiler.EndSample (BeginSample and EndSample count must match): OutlinePass #44

Closed
Delt06 opened this issue Oct 17, 2021 · 6 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Delt06
Copy link

Delt06 commented Oct 17, 2021

How to reproduce:

  • Open the Outline.URP project
  • Open Profiler window
  • Look at the console

The console becomes filled with these error messages:
image

Missing Profiler.EndSample (BeginSample and EndSample count must match): OutlinePass
Previous 5 samples:
	RenderTexture.SetActive
	OutlinePass
	Outline-256
	JobAlloc.Grow
	RenderLoop.CleanupNodeQueue
In the scope:
	OutlinePass
	Outline-256
	Render Camera
	UnityEngine.CoreModule.dll!UnityEngine.Rendering::RenderPipelineManager.DoRenderLoop_Internal() [Invoke]
[Invoke]
	PlayerLoop
Non matching Profiler.EndSample (BeginSample and EndSample count must match): OutlinePass
Previous 5 samples:
	Graphics.DrawProcedural
	RenderTexture.SetActive
	Graphics.DrawProcedural
	RenderTexture.SetActive
	Outline-256
In the scope:
	Outline-256
	Render Camera
	UnityEngine.CoreModule.dll!UnityEngine.Rendering::RenderPipelineManager.DoRenderLoop_Internal() [Invoke]
[Invoke]
	PlayerLoop
	Main Thread

Was able to reproduce in the Outline.URP project with 2019.4.17f1 and in a project that imports the package from npm with 2020.3.0f1.

@Delt06
Copy link
Author

Delt06 commented Oct 17, 2021

Found this: https://issuetracker.unity3d.com/issues/urp-unreleased-version-profiler-spams-errors-when-enabled-in-playmode
Looks like a bug from URP.
Not sure whether something can be done aside from removing the ProfilerScope from OutlinePass.

@Arvtesh
Copy link
Owner

Arvtesh commented Oct 18, 2021

Yes, I've spent some time on investigation and it seems to be an URP issue. At least I wasn't able to fix it on my side.

@Noxalus
Copy link

Noxalus commented Oct 28, 2021

I have the same issue using these packages version:

"com.unityfx.outline": "0.8.4",
"com.unityfx.outline.urp": "0.4.0",

But the issue doesn't exist if I go back to the version 0.3.0 of the com.unityfx.outline.urp package. So that's what I did!

@TheXRMonk
Copy link

I have the same issue using these packages version:

"com.unityfx.outline": "0.8.4",
"com.unityfx.outline.urp": "0.4.0",

But the issue doesn't exist if I go back to the version 0.3.0 of the com.unityfx.outline.urp package. So that's what I did!

Same issue and same solution here as well.

@Arvtesh Arvtesh self-assigned this Nov 14, 2021
@Arvtesh Arvtesh added the bug Something isn't working label Nov 14, 2021
@Arvtesh Arvtesh added this to the 0.8.5 milestone Nov 14, 2021
@Arvtesh
Copy link
Owner

Arvtesh commented Nov 18, 2021

Should be fixed in v0.8.5.

@james-arndt
Copy link

Should be fixed in v0.8.5.

Not fixed in latest. Issue is appearing on Mac platform, but not on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants