Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update winit to 22.2 #133

Merged
merged 2 commits into from
Jul 11, 2020
Merged

Update winit to 22.2 #133

merged 2 commits into from
Jul 11, 2020

Conversation

ArturKovacs
Copy link
Owner

Closes #128.

@ArturKovacs
Copy link
Owner Author

rust-windowing/winit#1496 fixed the issue that seems to cause #128. This PR updates winit to the newest version that contains the referred winit PR.

@RagibHasin please check if this fixes the issue for you

@Aloso
Copy link
Contributor

Aloso commented Jul 8, 2020

@ArturKovacs pro tip: You can write

gelatin = { path = "./subcrates/gelatin", version = "0.4" }

so cargo run uses the local copy of the crate and publishing on crates.io still works.

@ArturKovacs
Copy link
Owner Author

Thanks @Aloso, I'll change that right away! Where does one learn such things?

@RagibHasin
Copy link

So, far it is working alright with nightly, with that warning though.

$ cargo run                                                           
warning: variable does not need to be mutable                         
   --> src\picture_widget.rs:590:10                                   
    |                                                                 
590 |                     let mut borrowed = self.data.borrow_mut();  
    |                         ----^^^^^^^^                            
    |                         |                                       
    |                         help: remove this `mut`                 
    |                                                                 
    = note: `#[warn(unused_mut)]` on by default                       
                                                                      
warning: 1 warning emitted                                            
                                                                      
    Finished dev [unoptimized + debuginfo] target(s) in 2.48s         
     Running `target\debug\emulsion.exe`                              

@Aloso
Copy link
Contributor

Aloso commented Jul 10, 2020

Thanks @Aloso, I'll change that right away! Where does one learn such things?

I learned it just recently when reading this RFC.

@ArturKovacs
Copy link
Owner Author

@RagibHasin thank you for checking! And yeah I'll fix that warning sometime soon :D but it's not related to this issue so I'll just merge this as it is.

@Aloso hmm I just found that this is also part of the documentation I just haven't stumbled upon it. But yes, one can definitely learn a lot from just reading miscellaneous resources about Rust.

@ArturKovacs ArturKovacs merged commit bfb9f77 into master Jul 11, 2020
@ArturKovacs ArturKovacs deleted the fix-128 branch July 11, 2020 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on app open
3 participants