Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cucumber library): update to the latest cucumber library ver… #30

Conversation

thelazurite-cell
Copy link

…sion

Update the cucumber library to the latest version so that a user does not recieve any deprecation
warnings when they are attempting to install the library. Documentation has been updated to reflect
this, and any failing tests have been fixed.

BREAKING CHANGE: Any existing users of the library will need to update their cucumber imports from
'cucumber' to '@cucumber/cucumber'

re #22

…sion

Update the cucumber library to the latest version so that a user does not recieve any deprecation
warnings when they are attempting to install the library. Documentation has been updated to reflect
this, and any failing tests have been fixed.

BREAKING CHANGE: Any existing users of the library will need to update their cucumber imports from
'cucumber' to '@cucumber/cucumber'

re Arthy000#22
Copy link
Owner

@Arthy000 Arthy000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove package-lock.json from your branch? I switched this package to yarn, and yarn raises warnings when it detects a package-lock file.

…itignore

removed the package lock file as the repo has been switched to yarn, and add the file to the
gitignore so other maintainers do not run into this in the future

re Arthy000#22
@thelazurite-cell
Copy link
Author

I've removed the file and placed it in the .gitignore :)

@Arthy000 Arthy000 merged commit 68d65c3 into Arthy000:develop Mar 8, 2021
@thelazurite-cell thelazurite-cell deleted the refactor/update-cucumber-lib/issue-22 branch March 8, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants