Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testcafe 3.0 support #133

Closed
kojoru opened this issue Jun 27, 2023 · 4 comments
Closed

Testcafe 3.0 support #133

kojoru opened this issue Jun 27, 2023 · 4 comments

Comments

@kojoru
Copy link

kojoru commented Jun 27, 2023

Hi,

Can I ask you to investigate v3 support for Testcafe?

Is there anything we can do to facilitate peer dependencies upgrade from our side? I would be happy to assist, if so.

@Arthy000
Copy link
Owner

Arthy000 commented Jun 27, 2023

Hi @kojoru,

Not to worry, I'll start working on it right away. I admit I haven't checked on TestCafe's versions for a while now.

It's usually a pretty straightforward process, so if we are lucky you can even expect a new release tonight (well it really depends on your timezone but you get the idea)

Edit: serves me right, not as easy as usual

@Arthy000
Copy link
Owner

Arthy000 commented Jun 27, 2023

Okay, so it looks like there a few breaking changes, nothing I can't work out though.

HOWEVER, there is also an issue which seems to come from TC3 itself, I'd say a bug on their side or in one of their dependencies.
Basically, one of my most basic examples fails flakily, with an unhandled promise rejection in Chrome remote interface.
Chrome is up-to-date and the issue doesn't seem to occur on Firefox (though, as it is flaky, it could be very rare)
Full disclosure, I use a Mac so maybe the issue is limitted to my OS.
Screenshot 2023-06-27 at 22 12 12

IMHO it would be better to wait for TC version 3.0.1 before upgrading, the current version is pretty new and I usually wait for a week or two before attempting the update.

However if you're really confident you can work around the issue or you really need some new feature, I'll publish it despite my lack of confidence (probably as a rc version)

EDIT: the new version 3.0.1 is more stable, but basic http authentication still doesn't work. I tested it with vanilla testcafe so the issue doesn't come from this package.

@mokone91
Copy link

mokone91 commented Aug 1, 2023

it seems DevExpress/testcafe#7852 is fixed now, is it was a blocker?

Arthy000 added a commit that referenced this issue Aug 5, 2023
No changes were need on the runner side so any version previously supported should still be
supported now

#133
Arthy000 added a commit that referenced this issue Aug 5, 2023
No changes were need on the runner side so any version previously supported should still be
supported now

#133
@Arthy000
Copy link
Owner

Arthy000 commented Aug 5, 2023

It was not really a blocking issue, but earlier versions of TC3 were not stable enough to my taste.
Version 3.1.0 seems to have solved the issues I found while testing, so I made the change and just released the new version.

@Arthy000 Arthy000 closed this as completed Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants