This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
Remove dependency to UIKit. #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. Have you confirmed this works on iOS, tvOS, and macOS? |
|
Yes. The code works on all platform. In fact, with the import, the code would not compile for macOS (unless The reason why I am pushing for removal of this particular import is due to the Xcode previews in SwiftUI, which for some reason wants to compile all dependencies in the workspace, even when the FontBlaster is not a dependency of the macos target. This is a bug in Xcode, but the fix of removing the import seems like a good compromise until Apple can fix it. |
|
Alright, looks good. Tested it myself. |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.