Split BytecodeStorage into public/internal libraries
#684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakerockland
changed the title
BytecodeStorage into public/internal librariesBytecodeStorage into public/internal libraries
jakerockland
requested review from
ryley-o and
yoshiwarab
and removed request for
a team
ryley-o
approved these changes
May 4, 2023
jakerockland
changed the title
BytecodeStorage into public/internal librariesBytecodeStorage into public/internal libraries
ryley-o
approved these changes
May 5, 2023
deployments/engine/V3/internal-testing/staging-v3-react-demo-2/DEPLOYMENTS.md
Show resolved
Hide resolved
jakerockland
added a commit
that referenced
this pull request
May 5, 2023
* Support basic semantic versioning – and ensure interop with backwards compatible reads (tests added) * update the version string * minor adjustment and a song: https://www.youtube.com/watch\?v\=vOreqez4v9Y * Update to reflect better v1/v0/unknown versioning semantics * Update documentation and code structuring * Refactor size == 0 check * clean up offset checks * `STORE2`-compatible reads in `BytecodeStorage` (#681) * Update BytecodeStorage library to provide backwards-compatible reads that are compatible with SSTORE2 as the fallback read option, in advance of plans to split off reads into a shared external public utility library, in-companion to the embedded internal library for writes. * Whoops, forgot to add all the files yo * add support for manual-offset reads * SSTORE2 / explicit bytes reads restructure * Comment fix * Filename fix * Filename fix * Better typing for tests * spelling fixes * Split `BytecodeStorage` into public/internal libraries (#684) * basic MVP of split library (with tests) * Adjusted tests for split library setup * minor modifier adjustment * Adjust optimizer runs * optimizer order * nit * get interface from deployed contract * get interface from deployed contract * ensure libraries are linked * library linkkinnnn * More linking fixes in tests * update Engine Flex as PoC (#688) * fix the rest of the test bindingsgit diff * OPTIMIZOOOOOR * remove unnecessary using for * Fixed comment * public constants * Update library naming convention * DEPLOYOOOOOR * DEPLOYOOOOOR * format * Address nits --------- Co-authored-by: ryley-o <30364988+ryley-o@users.noreply.github.com> --------- Co-authored-by: ryley-o <30364988+ryley-o@users.noreply.github.com>
jakerockland
added a commit
that referenced
this pull request
May 5, 2023
* Remove all call-sites for purgeBytecode, before cleaning up library internals * Remove purge logic from library entirely * fix comment * Update to reflect TWO VERSIONS (https://www.youtube.com/watch\?v\=diIFhc_Kzng) * Update to reflect TWO VERSIONS (https://www.youtube.com/watch\?v\=diIFhc_Kzng) * Update contracts/libs/0.8.x/BytecodeStorageV1.sol Co-authored-by: ryley-o <30364988+ryley-o@users.noreply.github.com> * Update contracts/libs/0.8.x/BytecodeStorageV1.sol Co-authored-by: ryley-o <30364988+ryley-o@users.noreply.github.com> * Update contracts/libs/0.8.x/BytecodeStorageV1.sol Co-authored-by: ryley-o <30364988+ryley-o@users.noreply.github.com> * Add basic form of `BytecodeStorage` library versioning (#670) * Support basic semantic versioning – and ensure interop with backwards compatible reads (tests added) * update the version string * minor adjustment and a song: https://www.youtube.com/watch\?v\=vOreqez4v9Y * Update to reflect better v1/v0/unknown versioning semantics * Update documentation and code structuring * Refactor size == 0 check * clean up offset checks * `STORE2`-compatible reads in `BytecodeStorage` (#681) * Update BytecodeStorage library to provide backwards-compatible reads that are compatible with SSTORE2 as the fallback read option, in advance of plans to split off reads into a shared external public utility library, in-companion to the embedded internal library for writes. * Whoops, forgot to add all the files yo * add support for manual-offset reads * SSTORE2 / explicit bytes reads restructure * Comment fix * Filename fix * Filename fix * Better typing for tests * spelling fixes * Split `BytecodeStorage` into public/internal libraries (#684) * basic MVP of split library (with tests) * Adjusted tests for split library setup * minor modifier adjustment * Adjust optimizer runs * optimizer order * nit * get interface from deployed contract * get interface from deployed contract * ensure libraries are linked * library linkkinnnn * More linking fixes in tests * update Engine Flex as PoC (#688) * fix the rest of the test bindingsgit diff * OPTIMIZOOOOOR * remove unnecessary using for * Fixed comment * public constants * Update library naming convention * DEPLOYOOOOOR * DEPLOYOOOOOR * format * Address nits --------- Co-authored-by: ryley-o <30364988+ryley-o@users.noreply.github.com> --------- Co-authored-by: ryley-o <30364988+ryley-o@users.noreply.github.com> --------- Co-authored-by: ryley-o <30364988+ryley-o@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR builds on top of #668 and #670 to actualize the architecture discussed in #422 (comment) of a split public shared external reader library and an internal writer library.
This PR is intended to be atomically merged into
mainat the same time as #668 and #670 and is thus marked as "do not merge" until all three have been through review and are ready to merge. Because of this, we are not bumping the versions of the client CoreV3 contracts using this library with this changeset, as they are already version-bumped in #668.Note: that this PR is still marked as a WIP as we have not yet made the necessary changes to the deployment script of this PR, as that will be a "phase 2" update to this changeset after I have gotten an initial LGTM from reviewers on the overall architecture and code structure here.Our shared deployer script has been added, and deployment using this library linking approach has been validated end-to-end on goerli, with shared deployments of the library being deployed on both goerli and mainnet.
Pending the final approval of this PR, I will merge this as well as #668 and #670 into main, and we can consider the V1 version of this new
BytecodeStoragelibrary as released!! (closes #660).