Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide tokenIdToHashSeed consistency in V3 #665

Merged
merged 8 commits into from
Apr 27, 2023
Merged

Conversation

jakerockland
Copy link
Contributor

@jakerockland jakerockland commented Apr 26, 2023

Description of the change

Update CoreV3 for flagship and explorations to both support tokenIdToHashSeed and version bump to 3.1.0 / 3.1.1.

Additionally, refactor out a shared IGenArt721CoreContractExposesHashSeed interface to be used across all contracts that conform to this, removing it from the _Engine-specific core contract interface (this is safe, as no reliance on said interface outside of compile-time reliance is currently used – e.g. no usage in our subgraph, etc.).

@jakerockland jakerockland requested a review from a team as a code owner April 26, 2023 17:48
@jakerockland jakerockland enabled auto-merge (squash) April 26, 2023 17:48
Copy link
Contributor

@ryley-o ryley-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the interest of maintaining a reference to the solid understanding of our as-deployed flagship and explorations contracts, while also supporting any new deployments with these changes in our subgraph, I think the following might make sense:

  • make a new IGenArt721CoreContractV3p1 that is IGenArt721CoreContractV3, with the added new view function tokenIdToHashSeed defined in the interface

edit - discussed alternate solution offline that seems better

contracts/explorations/GenArt721CoreV3_Explorations.sol Outdated Show resolved Hide resolved
@jakerockland jakerockland disabled auto-merge April 26, 2023 20:55
@jakerockland jakerockland requested a review from ryley-o April 26, 2023 21:25
@jakerockland
Copy link
Contributor Author

In the interest of maintaining a reference to the solid understanding of our as-deployed flagship and explorations contracts, while also supporting any new deployments with these changes in our subgraph, I think the following might make sense:

  • make a new IGenArt721CoreContractV3p1 that is IGenArt721CoreContractV3, with the added new view function tokenIdToHashSeed defined in the interface

edit - discussed alternate solution offline that seems better

Updated to account for our discussion ser, re-requesting review 🙏

@jakerockland
Copy link
Contributor Author

@yoshiwarab moving you to CC, I don't think this PR actually needs multi-review.

cc @shantanubala as well.

@jakerockland jakerockland removed the request for review from yoshiwarab April 26, 2023 21:26
Copy link
Contributor

@ryley-o ryley-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Cc @lyaunzbe as this is a change that needs to be in the new polyptych minter 👍

@ryley-o ryley-o merged commit dfde29b into main Apr 27, 2023
@ryley-o ryley-o deleted the tokenIdToHashSeed branch April 27, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants