-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide tokenIdToHashSeed consistency in V3 #665
Conversation
…HashSeed and version bump to 3.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the interest of maintaining a reference to the solid understanding of our as-deployed flagship and explorations contracts, while also supporting any new deployments with these changes in our subgraph, I think the following might make sense:
- make a new
IGenArt721CoreContractV3p1
thatis IGenArt721CoreContractV3
, with the added new view functiontokenIdToHashSeed
defined in the interface
edit - discussed alternate solution offline that seems better
…ntracts into tokenIdToHashSeed
Updated to account for our discussion ser, re-requesting review 🙏 |
@yoshiwarab moving you to CC, I don't think this PR actually needs multi-review. cc @shantanubala as well. |
…ntracts into tokenIdToHashSeed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Cc @lyaunzbe as this is a change that needs to be in the new polyptych minter 👍
Description of the change
Update CoreV3 for flagship and explorations to both support tokenIdToHashSeed and version bump to 3.1.0 / 3.1.1.
Additionally, refactor out a shared
IGenArt721CoreContractExposesHashSeed
interface to be used across all contracts that conform to this, removing it from the_Engine
-specific core contract interface (this is safe, as no reliance on said interface outside of compile-time reliance is currently used – e.g. no usage in our subgraph, etc.).