Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try/catch generic minter deployment minter filter allowlisting #634

Merged
merged 4 commits into from
Apr 14, 2023

Conversation

ryley-o
Copy link
Contributor

@ryley-o ryley-o commented Apr 14, 2023

Description of the change

Add try/catch on generic minter deployment minter filter allowlisting.

This also reports+logs any necessary follow-on actions to the user running the script.

Tested on goerli to ensure WAI

follow on from #631, so it also fixes the bugged DEPLOYMENTS.md from the deployments in that PR.

@ryley-o ryley-o changed the title try/catch on generic minter deployment minter filter allowlisting, re… try/catch generic minter deployment minter filter allowlisting Apr 14, 2023
@ryley-o ryley-o self-assigned this Apr 14, 2023
@ryley-o ryley-o marked this pull request as ready for review April 14, 2023 17:50
@ryley-o ryley-o requested a review from a team as a code owner April 14, 2023 17:50
@ryley-o ryley-o requested a review from jakerockland April 14, 2023 17:50
@ryley-o ryley-o enabled auto-merge April 14, 2023 18:00
Copy link
Contributor

@jakerockland jakerockland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐

@ryley-o ryley-o merged commit 0a3d0c1 into main Apr 14, 2023
@ryley-o ryley-o deleted the try-catch-generic-minter-deploy branch April 14, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants