Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added new testnet minter info #632

Merged
merged 1 commit into from
Apr 14, 2023
Merged

added new testnet minter info #632

merged 1 commit into from
Apr 14, 2023

Conversation

ABDruid
Copy link
Contributor

@ABDruid ABDruid commented Apr 14, 2023

Description of the change

Included DA without settlement Goerli deployment address

reminder: Any mainnet deployments after 10 Jan 2023 should be tagged as Releases in this repository. This ensures that the deployed contract source code is easily verifiable by anyone.

@ABDruid ABDruid requested a review from a team as a code owner April 14, 2023 14:44
@ABDruid ABDruid requested a review from ryley-o April 14, 2023 14:44
@ryley-o ryley-o mentioned this pull request Apr 14, 2023
Merged
ryley-o
ryley-o approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@ryley-o ryley-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to go ahead and approve+merge this PR, because it aligns with the deployment logs in #631.

Will follow up to see why our minter deployment script did not record this automatically!

@ryley-o ryley-o merged commit 3498e91 into main Apr 14, 2023
@ryley-o ryley-o deleted the ABDruid-patch-1 branch April 14, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryley-o ryley-o ryley-o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ABDruid @ryley-o