Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update royalties docs, add diagram #571

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Conversation

ryley-o
Copy link
Contributor

@ryley-o ryley-o commented Mar 23, 2023

Description of the change

Update royalties documentation and add royalty registry override diagram.

This somewhat simplifies the information contained in this repository, and also points to our Art Blocks Docs site to point to a single source of truth for instructions on how to configure royalty registry override contracts.

@ryley-o ryley-o marked this pull request as ready for review March 23, 2023 21:59
@ryley-o ryley-o requested a review from a team as a code owner March 23, 2023 21:59
@ryley-o ryley-o requested a review from jakerockland March 23, 2023 21:59
Copy link
Contributor

@jakerockland jakerockland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic – thank you @ryley-o

Worth also getting @ABDruid's eyes on this and iterating as needed, though I don't think it needs to block this PR.

🔥 🙌

@jakerockland
Copy link
Contributor

@aaronpenne @chi011 y'all may also find this diagram useful re: rationalizing about how the RR works (when it is respected by platforms).

@jakerockland jakerockland merged commit b0752d4 into main Mar 23, 2023
@jakerockland jakerockland deleted the update-royalties-docs branch March 23, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants