Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ejectNextTokenTo admin-only function to SEA #549

Merged
merged 3 commits into from
Mar 20, 2023

Conversation

ryley-o
Copy link
Contributor

@ryley-o ryley-o commented Mar 17, 2023

Description of the change

Add admin-only ejectNextTokenTo admin-only function to give more options when artist wants to switch to a different minter.

** This is proposed to be folded into #504 **

This functionality is not required, but it does enable an artist to avoid having to mint the "next" token before switching to a different minter. It is gated to admin-only to prevent the artist from either maliciously or accidentally ejecting favored tokens from the "next token" slot.

Note that token ejection is restricted to only after an artist (or admin) has reset the project's auction. Additionally, if the project wishes to resume minting on the minter after a token is ejected, the next token will be re-populated with a new token when the artist re-configures their project.

@ryley-o ryley-o self-assigned this Mar 17, 2023
@ryley-o ryley-o marked this pull request as ready for review March 17, 2023 21:42
@ryley-o ryley-o requested a review from a team as a code owner March 17, 2023 21:42
@ryley-o ryley-o requested review from jakerockland and removed request for a team March 17, 2023 21:42
@ryley-o ryley-o changed the title add ejectNextTokenTo admin-only function add ejectNextTokenTo admin-only function to SEA Mar 17, 2023
@ryley-o ryley-o requested a review from lyaunzbe March 17, 2023 22:32
Copy link
Contributor

@jakerockland jakerockland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM – would encourage expanding on the inline documentation here to clarify why only one token will ever be in a "needs ejecting" state for a given project.

@ryley-o
Copy link
Contributor Author

ryley-o commented Mar 20, 2023

updated some comments and folding into #504 🙏

@ryley-o ryley-o merged commit 1f3eb2b into Serial-English-Auction-Minter Mar 20, 2023
@ryley-o ryley-o deleted the sea-eject-mint branch March 20, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants