Update dependency registry with supported contract overrides #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryley-o
changed the base branch from
main
to
ryley/plt-890-follow-on-inject-dependencies-for-flex
lindsgil
approved these changes
Nov 26, 2024
1 task
I think there is definitely a healthy amount of improvement we can make around access controls and permission granularity (e.g. at project level) in the future, but for now this is a good start 😃 |
Base automatically changed from
ryley/plt-890-follow-on-inject-dependencies-for-flex
to
main
November 26, 2024 16:22
…h-supported-contract-overrides
yoshiwarab
approved these changes
Nov 26, 2024
ryley-o
deleted the
ryley/plt-901-update-dependency-registry-with-supported-contract-overrides
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Update dependency registry with supported contract overrides.
fixes https://linear.app/art-blocks/issue/PLT-901/update-dependency-registry-with-supported-contract-overrides
This allows the dependency registry to add supported contracts in addition to what is defined on the core registry.
This supports the use case where a core contract is banned from minting on the shared minter suite, but has projects should be supported by the dependency registry (e.g. safe fallback if compromised partner admin keys).
Note: an event is also added when core registry is set, for future indexing capabilities.
TODO