Make admin pages more DRY. #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chesio
force-pushed
the
make-admin-pages-more-dry
branch
from
8478235 to
bcb9531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I refactored admin pages to make them more DRY:
get_current_tab,render_menu_pageandrender_menu_tabshave been moved to parent classAIOWPSecurity_Admin_Menuandrender_menu_pageis invoked from parent constructor now.set_menu_tabshas been removed, tabs are set in class constructor of every admin page instead.The codebase is now almost 700 lines shorter and far more clean, but there's no change in functionality, except that
get_current_tab()method now returns the first tab, if$_GET['tab']value is not a valid tab for given page.Greetings,
Česlav