Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a proper Python wrapper over the library bindings #43

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

Armavica
Copy link
Owner

@Armavica Armavica commented Jan 13, 2025

Instead of calling directly the Rust bindings, I made a proper Python wrapper. This creates some verbosity but also gives more flexibility and avoids monkey-patching.

Fixes #37.

@Armavica
Copy link
Owner Author

@maurosilber I think it is okay to remove the rebop.pyi file now that the docstrings and types can be obtained statically from Python code, is that correct? Can you still see typehints and docstrings in Pylance on this branch?

@maurosilber
Copy link
Contributor

Yes, that works with Pylance 👍

@Armavica Armavica merged commit 3b4140d into main Jan 14, 2025
18 checks passed
@Armavica Armavica deleted the lib branch January 14, 2025 13:31
@Armavica
Copy link
Owner Author

Great, thank you very much for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synchronize stub file docstrings with original docstrings
2 participants