Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show nearest mission modlist on the modlist list page #256

Merged
merged 8 commits into from
Sep 26, 2022
Merged

Show nearest mission modlist on the modlist list page #256

merged 8 commits into from
Sep 26, 2022

Conversation

veteran29
Copy link
Member

@veteran29 veteran29 commented Aug 28, 2022 •
edited
Loading

  • MissionClient method
  • Actual user interface that utilises it

@veteran29 veteran29 added the feature New feature or request label Aug 28, 2022
@veteran29 veteran29 marked this pull request as ready for review September 4, 2022 11:10
@veteran29 veteran29 requested a review from a team as a code owner September 4, 2022 11:10
@veteran29 veteran29 requested review from jskowronski39 and removed request for a team September 4, 2022 11:10
@veteran29
Copy link
Member Author

image

jskowronski39
jskowronski39 approved these changes Sep 8, 2022
View reviewed changes
Copy link
Collaborator

@jskowronski39 jskowronski39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good enough for now. Please consider making this upcoming mission widget more compact. Also Symfony security check is failing.

@veteran29
Copy link
Member Author

Updated the layout to be more compact:
image

@veteran29 veteran29 merged commit dac5d5d into dev Sep 26, 2022
@veteran29 veteran29 deleted the nearest-mission-modlist branch September 26, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskowronski39 jskowronski39 jskowronski39 approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veteran29 @jskowronski39