Skip to content

Commit

Permalink
✨ made the image checks run in parallel (#21)
Browse files Browse the repository at this point in the history
  • Loading branch information
hamars01 authored Dec 4, 2024
1 parent b9ab7ad commit b7b2c0b
Show file tree
Hide file tree
Showing 2 changed files with 51 additions and 32 deletions.
1 change: 1 addition & 0 deletions changes/202412041140.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
✨ made the image checks run in parallel
82 changes: 50 additions & 32 deletions cmd/images.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,42 +71,60 @@ func imagesCmdRun(_ *cobra.Command, _ []string) {
"------------------------------------------------------------------------------------------------\n\n",
)

sortedImages := make([]string, 0, len(imageMap))
for image := range imageMap {
sortedImages = append(sortedImages, image)
type result struct {
image string
icon string
err error
}
sort.Strings(sortedImages)

for _, image := range sortedImages {
var (
icon string
supportsArm, err = images.CheckLinuxArm64Support(image)
)

switch {
case err != nil:
icon = errorIcon
if debugEnabled {
fmt.Printf("Error: %s\n", err)
fmt.Printf("Pods: %s\n", imageMap[image])
}
if loggingEnabled {
log.Println(icon, " image: ", image, " error: ", err)
}
case supportsArm:
icon = successIcon
default:
latestImage := images.GetLatestImage(image)
latestSupportsArm, _ := images.CheckLinuxArm64Support(latestImage)
if latestSupportsArm {
icon = upgradeIcon
} else {
icon = failedIcon

results := make(chan result, len(imageMap))

for image := range imageMap {
go func(image string) {
var (
icon string
supportsArm, err = images.CheckLinuxArm64Support(image)
)

switch {
case err != nil:
icon = errorIcon
case supportsArm:
icon = successIcon
default:
latestImage := images.GetLatestImage(image)
latestSupportsArm, _ := images.CheckLinuxArm64Support(latestImage)
if latestSupportsArm {
icon = upgradeIcon
} else {
icon = failedIcon
}
}
}

fmt.Printf("%s %s %s\n", icon, image, images.GetFriendlyErrorMessage(err))
results <- result{image: image, icon: icon, err: err}
}(image)
}

var resultList []result
for range imageMap {
resultList = append(resultList, <-results)
}

sort.Slice(resultList, func(i, j int) bool {
return resultList[i].image < resultList[j].image
})

for _, res := range resultList {
fmt.Printf("%s %s %s\n", res.icon, res.image, images.GetFriendlyErrorMessage(res.err))
if res.err != nil && debugEnabled {
fmt.Printf("Error: %s\n", res.err)
fmt.Printf("Pods: %s\n", imageMap[res.image])
}
if res.err != nil && loggingEnabled {
log.Println(res.icon, " image: ", res.image, " error: ", res.err, "\n", imageMap[res.image])
}
}

}

func init() {
Expand Down

0 comments on commit b7b2c0b

Please sign in to comment.