-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add custom errors #468
Comments
Hi @gershon can I work on this? |
I would love to work on this issue @gershon here is my profile: https://app.onlydust.com/u/Jemiiah |
hello @gershon please i would love to work on this issue tomorrow once the OD hack starts :) |
hello @gershon please can i work on this issue tomorrow once the OD hack starts :) |
hello @gershon please i would love to work on this issue tomorrow once the OD hack starts :) |
Hi @gershon would be happy to take up this issue by tomorrow |
@gershon kindly assign me this task as i would like to make it my first contribution to this project. |
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedHi, I have been contributing in odhacks for quite some time now and have expertise in rust and blockchain specs , few of them are
How I plan on tackling this issueI will integrate sdk core custom errorin sdk for better error handling and ease of debugging |
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedI am a Web3/frontend developer How I plan on tackling this issueI will
|
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedi'm a solidity and cairo smart contract developer with over 2 years experience and belive i have the skill set for the task |
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedi am a frontend developer with experience using JS and TS for type safety How I plan on tackling this issueI will start by defining the custom error types that I need to create, such as INVALID_START_AMOUNT, INVALID_END_DATE, etc. These error types will help categorize specific issues that may arise during SDK usage. For each error type, I will craft a meaningful error message that provides context. For example, I will create a message like "Invalid start date. Start date (${startDate}) cannot be in the past." This will give users a clear understanding of what went wrong. I will ensure that each error message includes a link to the relevant documentation (https://docs.arkproject.dev/) to assist users in troubleshooting and understanding the error better. I will implement these custom errors in the SDK core, making sure to use the appropriate syntax and structure as per the coding standards of the project. I will ensure that these errors are thrown at the correct instances where validation fails. After implementing the custom errors, I will write tests to validate that the errors are thrown correctly under the intended circumstances. This will help confirm that the error handling works as expected. I will update any relevant documentation to include information about the new custom errors, their meanings, and how they can be resolved, ensuring that developers using the SDK have clear guidance. |
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedI have experience in building SDKs and handling error management in various systems. I’ve implemented custom error handling in JavaScript/TypeScript projects, providing developers with clear error messages, types, and links to relevant documentation. This ensures a smooth debugging experience and improves SDK usability. My familiarity with tools like Next.js and TypeScript enables me to create a robust error-handling framework for this project. How I plan on tackling this issueI would start by creating a custom error class that standardizes error types, messages, and links to documentation. This class would include parameters for the error type (e.g., |
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedhello i am a frontend dev and blockchain developer How I plan on tackling this issueHave a type (e.g., INVALID_START_AMOUNT, INVALID_END_DATE). |
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedi am a blockchain developer with strong background in cario, typescript,javascript etc. i will love to work on this issue, kindly assign How I plan on tackling this issueImplement custom SDK errors by defining error types such as INVALID_START_AMOUNT and INVALID_END_DATE, along with contextual messages like "Invalid start date. Start date (${startDate}) cannot be in the past." Each error should also include a link to the relevant documentation at https://docs.arkproject.dev/ to aid in debugging and enhance user experience. |
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedHey, I am Bhavya, a seasoned frontend engineer with two years of professional experience. I have been working with react, react native, nextjs, typescript and javascript and have become very proficient in it. How I plan on tackling this issueTo approach the problem, we can create a custom error handling system that includes error types, context-specific messages, and documentation links. Each error can include: An errorType that describes the nature of the error. This approach improves SDK usage by: Providing meaningful error messages with context. |
Hi @NueloSE any update on this? |
@ptisserand I'd need more context on
This would help me implement, use, and link it to the related docs. Kindly assist |
Hi @NueloSE,
You should create your contribution branch from Lmk if you need more guidances or informations. |
Thank you this makes more sense now, I will be making a pr b4 end of 2mrw |
@gershon I made a PR and no review yet... |
Hi @NueloSE, I'll review it shortly. |
## Description This PR adds custom error handling to this project by defining several new error types. These errors are defined in the packages/core/src/errors directory. ## What type of PR is this? (check all applicable) - [x] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents Fixes #468 ## Added tests? - [x] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [x] 🙅 no documentation needed
Closed by #480 |
Add and use sdk core custom errors to facilitate sdk usage and debug.
The text was updated successfully, but these errors were encountered: