-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core-transaction-pool): add type, interfaces and sort out structural issues #2448
Conversation
The ci/circleci: test-node10-unit job is failing as of b319913ce5593179f4d4bec2adc33e3e8d6e48cb. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
70f1c5d
to
ea79251
Compare
Codecov Report
@@ Coverage Diff @@
## 2.4 #2448 +/- ##
=========================================
- Coverage 68.25% 67.9% -0.35%
=========================================
Files 387 386 -1
Lines 8445 8403 -42
Branches 393 435 +42
=========================================
- Hits 5764 5706 -58
- Misses 2631 2644 +13
- Partials 50 53 +3
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## 2.4 #2448 +/- ##
=========================================
- Coverage 68.25% 67.9% -0.35%
=========================================
Files 387 386 -1
Lines 8445 8403 -42
Branches 393 435 +42
=========================================
- Hits 5764 5706 -58
- Misses 2631 2644 +13
- Partials 50 53 +3
Continue to review full report at Codecov.
|
Proposed changes
Adds more types and interfaces and also sorts out some structural issues.
Types of changes
Checklist