Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add more types and interfaces #2427

Merged
merged 9 commits into from
Apr 16, 2019
Merged

refactor: add more types and interfaces #2427

merged 9 commits into from
Apr 16, 2019

Conversation

faustbrian
Copy link
Contributor

Proposed changes

Add types, interfaces and fix various minor issues.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@codecov-io
Copy link

codecov-io commented Apr 16, 2019

Codecov Report

Merging #2427 into 2.4 will decrease coverage by 0.16%.
The diff coverage is 46.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4    #2427      +/-   ##
==========================================
- Coverage   68.08%   67.91%   -0.17%     
==========================================
  Files         385      385              
  Lines        8444     8438       -6     
  Branches      430      390      -40     
==========================================
- Hits         5749     5731      -18     
- Misses       2647     2660      +13     
+ Partials       48       47       -1
Impacted Files Coverage Δ
packages/crypto/src/blocks/block.ts 86.66% <ø> (-0.25%) ⬇️
packages/core-utils/src/delegate-calculator.ts 100% <ø> (ø) ⬆️
...se/src/repositories/wallets-business-repository.ts 88.23% <ø> (ø) ⬆️
packages/core-utils/src/supply-calculator.ts 100% <ø> (ø) ⬆️
packages/core-container/src/config/file-loader.ts 15.62% <ø> (ø) ⬆️
packages/core-p2p/src/peer-guard.ts 82.5% <ø> (+2.01%) ⬆️
...pto/src/transactions/builders/transactions/ipfs.ts 72% <ø> (ø) ⬆️
packages/core-database/src/database-service.ts 27.48% <ø> (ø) ⬆️
.../src/repositories/delegates-business-repository.ts 84.21% <ø> (ø) ⬆️
packages/core-p2p/src/peer-communicator.ts 75.94% <ø> (-0.31%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e794b54...c87f6bc. Read the comment docs.

@ghost
Copy link

ghost commented Apr 16, 2019

The ci/circleci: test-node11-unit job is failing as of 6f885577246ae5330ffc1cdbe45aab816f728f5d. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@faustbrian faustbrian marked this pull request as ready for review April 16, 2019 10:09
@faustbrian faustbrian merged commit d012ce8 into 2.4 Apr 16, 2019
@ghost ghost deleted the refactor/types branch April 16, 2019 10:09
@ghost ghost removed the Status: In Progress label Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants