Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-database-postgres): add type hints and return types #2421

Merged
merged 5 commits into from
Apr 15, 2019

Conversation

faustbrian
Copy link
Contributor

Proposed changes

Add interfaces, types, type hints and return types to core-database-postgres.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@ghost
Copy link

ghost commented Apr 15, 2019

The ci/circleci: test-node10-unit job is failing as of d808fd72ce62499e783f52285bbe92db8e975801. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io
Copy link

codecov-io commented Apr 15, 2019

Codecov Report

Merging #2421 into 2.4 will increase coverage by 0.03%.
The diff coverage is 63.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4    #2421      +/-   ##
==========================================
+ Coverage   66.31%   66.34%   +0.03%     
==========================================
  Files         398      398              
  Lines        8565     8540      -25     
  Branches      392      436      +44     
==========================================
- Hits         5680     5666      -14     
+ Misses       2839     2827      -12     
- Partials       46       47       +1
Impacted Files Coverage Δ
packages/core-api/src/repositories/blocks.ts 51.85% <ø> (+1.85%) ⬆️
packages/core-api/src/repositories/repository.ts 90% <ø> (ø) ⬆️
packages/core-api/src/repositories/transactions.ts 83.33% <0%> (+1.88%) ⬆️
packages/core-database/src/database-service.ts 27.48% <0%> (ø) ⬆️
.../core-database-postgres/src/repositories/rounds.ts 71.42% <0%> (-3.58%) ⬇️
...ase/src/repositories/blocks-business-repository.ts 80% <100%> (-1.25%) ⬇️
...e-database-postgres/src/repositories/migrations.ts 100% <100%> (ø) ⬆️
...ges/core-database-postgres/src/models/migration.ts 100% <100%> (ø) ⬆️
...c/repositories/transactions-business-repository.ts 97.01% <100%> (-0.09%) ⬇️
.../core-database-postgres/src/postgres-connection.ts 57.94% <100%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5ea48...e696bf8. Read the comment docs.

@faustbrian faustbrian marked this pull request as ready for review April 15, 2019 09:27
@faustbrian faustbrian merged commit 9ddce7a into 2.4 Apr 15, 2019
@ghost ghost deleted the refactor/db-pg-types branch April 15, 2019 09:29
@ghost ghost removed the Status: In Progress label Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants