Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core-logger): unit tests for logger and manager #2373

Merged
merged 3 commits into from
Apr 9, 2019
Merged

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Apr 7, 2019

Proposed changes

Increased coverage for core-logger and some refactoring.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@ghost
Copy link

ghost commented Apr 7, 2019

The ci/circleci: test-node10-functional job is failing as of ac02742ad3ad2975b0c47880fd252051beea55a5. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io
Copy link

codecov-io commented Apr 7, 2019

Codecov Report

Merging #2373 into 2.4 will increase coverage by 0.07%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4    #2373      +/-   ##
==========================================
+ Coverage   68.44%   68.51%   +0.07%     
==========================================
  Files         403      403              
  Lines        8560     8564       +4     
  Branches      377      377              
==========================================
+ Hits         5859     5868       +9     
+ Misses       2658     2653       -5     
  Partials       43       43
Impacted Files Coverage Δ
packages/core-logger-winston/src/driver.ts 85.71% <0%> (-6.6%) ⬇️
packages/core-logger/src/logger.ts 61.9% <53.84%> (+28.57%) ⬆️
packages/core-logger/src/manager.ts 100% <0%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3646ed5...dccaa7d. Read the comment docs.

@faustbrian faustbrian marked this pull request as ready for review April 7, 2019 11:45
@faustbrian faustbrian merged commit f60916f into 2.4 Apr 9, 2019
@ghost ghost deleted the refactor/logger branch April 9, 2019 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants