Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-p2p): don't test private methods in the peer guard #2359

Merged
merged 4 commits into from
Apr 3, 2019

Conversation

faustbrian
Copy link
Contributor

Proposed changes

Marks the determine* methods of the peer guard as private and adjusts tests to only test the public API.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@codecov-io
Copy link

Codecov Report

Merging #2359 into 2.4 will not change coverage.
The diff coverage is 81.81%.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.4    #2359   +/-   ##
=======================================
  Coverage   66.47%   66.47%           
=======================================
  Files         400      399    -1     
  Lines        8535     8535           
  Branches      375      375           
=======================================
  Hits         5674     5674           
  Misses       2818     2818           
  Partials       43       43
Impacted Files Coverage Δ
packages/core-p2p/src/monitor.ts 66.8% <100%> (ø) ⬆️
packages/core-p2p/src/peer.ts 40.35% <100%> (ø) ⬆️
packages/core-p2p/src/guard.ts 75% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0eb903...7d4b7a2. Read the comment docs.

@faustbrian faustbrian merged commit e0a4bb6 into 2.4 Apr 3, 2019
@ghost ghost deleted the refactor/p2p-guard branch April 3, 2019 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants