Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Monte Carlo generator of central galaxies #102

Merged
merged 7 commits into from
Mar 4, 2025
Merged

Add Monte Carlo generator of central galaxies #102

merged 7 commits into from
Mar 4, 2025

Conversation

aphearin
Copy link
Collaborator

@aphearin aphearin commented Mar 4, 2025

Add Monte Carlo generator of central galaxies.

This PR also breaks the API of the mc_subhalos function. The order of the positional arguments used to be mc_subhalos(ran_key, lgmp_min, z_obs, **kwargs), but now the signature is mc_subhalos(ran_key, z_obs, **kwargs). The reason for the change is to support an input argument hosts_logmh_at_z, as opposed to generating a volume-complete sample of halos down to some limiting mass.

@aphearin aphearin merged commit 71d137c into main Mar 4, 2025
7 checks passed
@aphearin aphearin deleted the mc_centrals branch March 4, 2025 17:14
aphearin added a commit to ArgonneCPAC/diffstarpop that referenced this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant