Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LANL Ti model #123

Merged
merged 12 commits into from
Feb 12, 2022
Merged

LANL Ti model #123

merged 12 commits into from
Feb 12, 2022

Conversation

reverendbedford
Copy link
Collaborator

This PR adds a LANL model for single crystal Ti deformation.

@tianjuchen
Copy link
Collaborator

All checks have passed 😄 @reverendbedford

Copy link
Collaborator Author

@reverendbedford reverendbedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this is pretty good. There are a few specific comments but generally,

  1. Change how you're dealing with the sizes of things so that the model would work for any number of slip and twin systems (suggestions in comments).
  2. Add documentation
  3. Clean up the formatting (indentation mostly)

Once you do that I can see a couple of places we can make this run faster and then we'll be done.

doc/sphinx/cp/sliphardening/LANLTiModel.rst Show resolved Hide resolved
examples/cp/hucocks/generate_model.py Outdated Show resolved Hide resolved
examples/cp/ti_rolling.py Show resolved Hide resolved
src/cp/slipharden.cxx Outdated Show resolved Hide resolved
src/cp/slipharden.cxx Outdated Show resolved Hide resolved
src/cp/slipharden.cxx Outdated Show resolved Hide resolved
src/cp/slipharden.cxx Show resolved Hide resolved
src/cp/slipharden.cxx Outdated Show resolved Hide resolved
src/cp/slipharden.cxx Outdated Show resolved Hide resolved
src/cp/slipharden.cxx Outdated Show resolved Hide resolved
@reverendbedford reverendbedford merged commit 998a0b6 into dev Feb 12, 2022
@reverendbedford reverendbedford deleted the test_forest branch February 12, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants