generator: fix message length table overflow #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicrub
reviewed
Aug 16, 2019
| @@ -681,11 +676,12 @@ MAVLINK_HELPER uint8_t mavlink_frame_char_buffer(mavlink_message_t* rxmsg, | |||
| status->parse_state = MAVLINK_PARSE_STATE_GOT_PAYLOAD; | |||
| } | |||
| #ifdef MAVLINK_CHECK_MESSAGE_LENGTH | |||
| if (rxmsg->len != MAVLINK_MESSAGE_LENGTH(rxmsg->msgid)) | |||
| if (rxmsg->len < mavlink_min_message_length(rxmsg) || | |||
| rxmsg->len > mavlink_max_message_length(rxmsg)) | |||
There was a problem hiding this comment.
I have a feeling one of these bounds checks is missing a >= or <=
julianoes
force-pushed
the
fix-check-message-length
branch
from
3ff976b to
bbefc9a
Compare
OXINARF
requested changes
Aug 19, 2019
|
@OXINARF do you need any other changes? |
|
@julianoes It should be squashed. And my comment regarding the formatting still applies (given we aren't fixing it here, it's better to not make it worse). |
Since MAVLink 2 we can have message IDs > 256 and we should probably look up the message length in the mavlink_msg_entry dict instead.
julianoes
force-pushed
the
fix-check-message-length
branch
from
f1ee362 to
4e5107d
Compare
|
Ok, I squashed it to one commit and made the |
|
so... spaces wins? |
|
@magicrub I'm very much in favor of spaces but I'm not a maintainer here, so I don't think it should be up to me. 😄 |
|
I'm on team SPACES |
|
Anything else needed here? As said the tab vs. spaces discussion should not interfere with this bugfix in my opinion. |
|
Bump 🥺. |
|
I'm not too fussed by the whitespace, merging, thanks! |
julianoes
added a commit
to mavlink/mavlink
that referenced
this pull request
Sep 17, 2019
Includes at least these two bugfixes: ArduPilot/pymavlink#343 ArduPilot/pymavlink#344
hamishwillee
pushed a commit
to mavlink/mavlink
that referenced
this pull request
Sep 17, 2019
Includes at least these two bugfixes: ArduPilot/pymavlink#343 ArduPilot/pymavlink#344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since MAVLink 2 we can have message IDs > 256 and we should probably look up the message length in the mavlink_msg_entry dict instead.
Fixes #145.