AP_Scripting:Add disarm on low copter flipping LUA example #29081
Conversation
| -- Check roll and pitch | ||
| local roll = ahrs:get_roll() * 57.2958 -- Convert radians to degrees | ||
| local pitch = ahrs:get_pitch() * 57.2958 -- Convert radians to degrees | ||
|
|
There was a problem hiding this comment.
no big deal but maybe we could remove these extra blank lines
|
|
||
| if math.abs(roll) > ANGLE_THRESH or math.abs(pitch) > ANGLE_THRESH then | ||
| -- Disarm the drone | ||
| arming:disarm() -- |
There was a problem hiding this comment.
extra "--" at the end of this line that can probably be deleted
| local rotation_downward = 25 | ||
| local ALT_THRESH = 250 -- Altitude in which in centimeters | ||
| local ANGLE_THRESH = 80 -- Roll/Pitch angle threshold in degrees | ||
|
|
There was a problem hiding this comment.
Not a blocker but normally we print a message to tell the user that the script has been loaded.
gcs:send_text(1, "copter-disarm-on-flip script loaded")
| end | ||
| end | ||
| else | ||
| gcs:send_text(1, "No valid data from downward rangefinder!") |
There was a problem hiding this comment.
This is going to spam the user at 100hz so perhaps add a "return update(), 1000" to slow it down
|
thanks for adding this. I've made a couple of comments but it's pretty close to merge-able. Could we rename it to start with "copter-"? I think the script is only valid for Copter so having the vehicle at the front makes it more likely that users who can use it will find it and others can quickly ignore it |
|
@rmackay9 I dont think this actually works, right? unless somehow the RF is updating so slowly that it still shows close to ground as it rotates toward the sky to get the attitude limits evoked... |
Contribution from a user who wanted to share it