CurrentState: honor MAVLinkInterface.speechenable #3258
Conversation
|
What about multi vehicle configurations ? Speech is the only feedback for changes on a non selected vehicle and this disables it as well... |
|
I was thinking about this in the context of multi vehicle applications too. "Mode changed to X", "Heading to Waypoint X", without any indication of which vehicle it came from, is, at best, unhelpful. At worst, it's overwhelming vocal spam. Especially if you have a large swarm. If that's not convincing, then I can reduce this PR to just making CurrentState honor the speechenable flag. That way plugins have the ability to control it, and we can add options for the stock behavior in the future. |
robertlong13
force-pushed
the
pr/silence_redundant_links
branch
from
54049d1 to
adfbddb
Compare
MainV2.cs
Outdated
|
|
||
| // Disable speech on old port and enable it on the new one | ||
| if (_comPort != null) _comPort.speechenabled = false; | ||
| if (value != null) value.speechenabled = true; |
There was a problem hiding this comment.
what if it was disabled before hand?
There was a problem hiding this comment.
Currently, we don't disable this on any interfaces that we also set as MainV2.comPort. I can't imagine a case where we want some interfaces to speak but don't want the currently selected interface to speak (if you want no interfaces to speak, this doesn't override the global Speech.speechEnable)
I can definitely see that the hard-coding of false on the old port, is pretty limiting though.
robertlong13
force-pushed
the
pr/silence_redundant_links
branch
2 times, most recently
from
b7baa03 to
ce8ae41
Compare
robertlong13
changed the title
|
@meee1, I have decided to limit the scope of this PR to just the bugfix. I can handle silencing/unsilencing in a plugin. |
robertlong13
force-pushed
the
pr/silence_redundant_links
branch
from
ce8ae41 to
f00dd6d
Compare
|
I'm okay with it, but the decision to merge is ultimately up to Michael. |
Some speech events, like mode changes, fire off on all connected com ports, not just the primary. Additionally,
CurrentStateignores thespeechenableflag of theMAVLinkInterfacethat it's attached to, causing it to go off even for interfaces that are supposed to be silent.This PR makes
CurrentStatehonor thespeechenableflag. Additionally, it setsspeechenableon an interface whenMainV2.comPortis set to that interface, and clearsspeechenableon the old interface thatMainV2.comPortwas pointing to.