Skip to content

Commit

Permalink
Wide gamut and platform view integration test. (#138837)
Browse files Browse the repository at this point in the history
In flutter/engine#48190 I discovered that overlay surfaces were not constructed with wide gamut settings. This adds a test that will fail until this is fixed.
  • Loading branch information
jonahwilliams authored Nov 27, 2023
1 parent 397fd25 commit 389ebd4
Show file tree
Hide file tree
Showing 4 changed files with 123 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,15 @@ void main() {
app.run(app.Setup.drawnImage);
await tester.pumpAndSettle(const Duration(seconds: 2));

const MethodChannel channel = MethodChannel('flutter/screenshot');
final List<Object?> result =
await channel.invokeMethod('test') as List<Object?>;
expect(_findColor(result, <double>[0.0, 1.0, 0.0]), isTrue);
});
testWidgets('draw image with wide gamut works ontop of platform view with blur', (WidgetTester tester) async {
app.run(app.Setup.drawnImageAndPlatformView);
await tester.pumpAndSettle(const Duration(seconds: 2));

const MethodChannel channel = MethodChannel('flutter/screenshot');
final List<Object?> result =
await channel.invokeMethod('test') as List<Object?>;
Expand Down
24 changes: 24 additions & 0 deletions dev/integration_tests/wide_gamut_test/ios/Runner/AppDelegate.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import UIKit
import Flutter

@UIApplicationMain
@objc class AppDelegate: FlutterAppDelegate {
override func application(
_ application: UIApplication,
didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
) -> Bool {
GeneratedPluginRegistrant.register(with: self)

var registrar = self.registrar(forPlugin: "plugin-name")
let factory = FLNativeViewFactory(messenger: registrar!.messenger())
self.registrar(forPlugin: "<plugin-name>")!.register(
factory,
withId: "<dummy-view>")

return super.application(application, didFinishLaunchingWithOptions: launchOptions)
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import Foundation

import Flutter
import UIKit

class FLNativeViewFactory: NSObject, FlutterPlatformViewFactory {
private var messenger: FlutterBinaryMessenger

init(messenger: FlutterBinaryMessenger) {
self.messenger = messenger
super.init()
}

func create(
withFrame frame: CGRect,
viewIdentifier viewId: Int64,
arguments args: Any?
) -> FlutterPlatformView {
return FLNativeView(
frame: frame,
viewIdentifier: viewId,
arguments: args,
binaryMessenger: messenger)
}

public func createArgsCodec() -> FlutterMessageCodec & NSObjectProtocol {
return FlutterStandardMessageCodec.sharedInstance()
}
}

class SolidColorView: UIView {
override init(frame: CGRect) {
super.init(frame: frame)
setupView()
}

required init?(coder aDecoder: NSCoder) {
super.init(coder: aDecoder)
setupView()
}

private func setupView() {
backgroundColor = .blue
}
}


class FLNativeView: NSObject, FlutterPlatformView {
private var view: UIView

init(
frame: CGRect,
viewIdentifier viewId: Int64,
arguments args: Any?,
binaryMessenger messenger: FlutterBinaryMessenger?
) {
view = SolidColorView()
super.init()
}

func view() -> UIView {
return view
}
}
22 changes: 22 additions & 0 deletions dev/integration_tests/wide_gamut_test/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ enum Setup {
canvasSaveLayer,
blur,
drawnImage,
drawnImageAndPlatformView
}

void run(Setup setup) {
Expand Down Expand Up @@ -244,6 +245,19 @@ Future<ui.Image> _loadImage() async {
return (await codec.getNextFrame()).image;
}

class DummyPlatformView extends StatelessWidget {
const DummyPlatformView({super.key});

@override
Widget build(BuildContext context) {
return const SizedBox(
width: 400,
height: 400,
child: UiKitView(viewType: '<dummy-view>'),
);
}
}

class MyHomePage extends StatefulWidget {
const MyHomePage(this.setup, {super.key, required this.title});

Expand Down Expand Up @@ -285,6 +299,14 @@ class _MyHomePageState extends State<MyHomePage> {
imageWidget = Image.memory(base64Decode(_displayP3Logo));
case Setup.drawnImage:
imageWidget = CustomPaint(painter: _SaveLayerDrawer(_image));
case Setup.drawnImageAndPlatformView:
imageWidget = Stack(
children: <Widget>[
const DummyPlatformView(),
Image.memory(base64Decode(_displayP3Logo)),
BackdropFilter(filter: ui.ImageFilter.blur(sigmaX: 6, sigmaY: 6), child: const SizedBox(width: 400, height: 400)),
],
);
case Setup.canvasSaveLayer:
imageWidget = CustomPaint(painter: _SaveLayerDrawer(_image));
case Setup.blur:
Expand Down

0 comments on commit 389ebd4

Please sign in to comment.