Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part Name defintions added - some notes #2363

Closed
Jegelewicz opened this issue Nov 7, 2019 · 4 comments
Closed

Part Name defintions added - some notes #2363

Jegelewicz opened this issue Nov 7, 2019 · 4 comments
Labels
Function-CodeTables Priority-Normal (Not urgent) Normal because this needs to get done but not immediately.

Comments

@Jegelewicz
Copy link
Member

Jegelewicz commented Nov 7, 2019

A volunteer at NMMNH created definitions for all of the undefined part names used by ES collections. While transferring them to the code table I noticed the following:

malar = zygomatic
Zygomatic is not in the code table, but I could see it being added. These two terms apparently refer to the same bone? Do we need them both? Could we relate them if we do to facilitate searches?

chevron = haemal arch
haemal arch is not in the code table. See above.

magnum = capitate
capitate is not in the code table. See above.

unciform = hamate
hamate is not in the code table. See above.

scute is a specific type of osteoderm, but also "A scute or scutum (Latin scutum, plural: scuta "shield") is a bony external plate or scale overlaid with horn, as on the shell of a turtle, the skin of crocodilians, and the feet of birds. The term is also used to describe the anterior portion of the mesonotum in insects as well as some arachnids (e.g., the family Ixodidae, the scale ticks)." Here is another instance of the "foot" problem. Nicole has suggested a different treatment for osteoderm/scute - will put in a separate issue.

pes=foot
Perhaps this is the answer to #2328 vertebrates should use "pes" and inverts "foot".

podial
Unable to edit definition. Suggest definition to be:
Unspecified bones of the wrist and ankle. In digitigrade and unguligrade animals the podials form the second joint in the limb after the elbow or knee.

sternal
Any bone which is associated with the sternum.
Is this necessary?

Apologies in advance if there are any misspellings in the definitions recently added. If any of them are totally incorrect, please either correct them or let me know.

@dustymc I thought I would be cool and place links from the definitions to Wikipedia, but my attempt at that with "angular" just messed up that line of the code table. Can you fix that one for me? Thank you!!!

@Jegelewicz Jegelewicz added Function-CodeTables Priority-Normal (Not urgent) Normal because this needs to get done but not immediately. labels Nov 7, 2019
@dustymc
Copy link
Contributor

dustymc commented Nov 7, 2019

You had mismatched parens, and that code is sanitized only by access. I did this:

update 
    ctspecimen_part_name 
set 
  description='A bone of the mandible connected to all other jaw bones. In advanced therapsids, including mammals, the tympanic bone is a modified angular. <a target="_blank" class="external" href="https://en.wikipedia.org/wiki/Angular_bone">Wikipedia</a>' 
where 
  part_name='angular';

http://handbook.arctosdb.org/how_to/developer-guide.html#urls

podial

I just synced them - you can edit now.

@Jegelewicz
Copy link
Member Author

Great! Now I need to go back and add all of those wiki links.....

@Jegelewicz
Copy link
Member Author

Wiki links that volunteer provided have been added. Thanks @dustymc

but I still cant edit podial.

image

@dustymc
Copy link
Contributor

dustymc commented Nov 8, 2019

Apparently I'm not as bilingual as I'd like to be...

Maybe for real this time.

@Jegelewicz Jegelewicz mentioned this issue Dec 3, 2019
1 task
@dustymc dustymc closed this as completed Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Function-CodeTables Priority-Normal (Not urgent) Normal because this needs to get done but not immediately.
Projects
None yet
Development

No branches or pull requests

2 participants