Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused permissions #2479

Merged
merged 2 commits into from
Jan 14, 2025
Merged

remove unused permissions #2479

merged 2 commits into from
Jan 14, 2025

Conversation

Donnnno
Copy link
Collaborator

@Donnnno Donnnno commented Jan 6, 2025

These are all permissions currently in Arcticons

Scherm­afbeelding 2025-01-06 om 15 43 17

@Donnnno
Copy link
Collaborator Author

Donnnno commented Jan 6, 2025

let's see how many we can remove without breaking the app

@Donnnno
Copy link
Collaborator Author

Donnnno commented Jan 14, 2025

I've removed these permissions and haven't found an issue so far:

    <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED" tools:node="remove" />
    <uses-permission android:name="android.permission.SET_WALLPAPER" tools:node="remove" />
    <uses-permission android:name="android.permission.WAKE_LOCK" tools:node="remove" />
    <uses-permission android:name="${applicationId}.DYNAMIC_RECEIVER_NOT_EXPORTED_PERMISSION" tools:node="remove" />
    <uses-permission android:name="android.permission.FOREGROUND_SERVICE" tools:node="remove" />

The license checker is also removed in the next version.

@Donnnno Donnnno marked this pull request as ready for review January 14, 2025 21:13
@Donnnno Donnnno merged commit 574154a into main Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant