Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100+ new icons and a few fixes #2185

Merged
merged 4 commits into from
Jul 15, 2024
Merged

100+ new icons and a few fixes #2185

merged 4 commits into from
Jul 15, 2024

Conversation

wwwwwwari
Copy link
Contributor

This PR includes:

  • Add 100 new icons including some popular Laos apps and requested apps
  • Add 11 new apps using existing icons
  • Fix 3 previously submitted icons (Meb and Line Dictionaries)

Note: I've reinstalled my OS and I'm not sure if I set the Inkscape's settings wrong somewhere, but the XML of all new icons have their stroke-width set to .265. However, the icons themselves look correct with that value, and forcing the values to be 1 makes the strokes thicker than they should be, at least on my PC.

Please let me know if I should change something somewhere.

@Donnnno
Copy link
Collaborator

Donnnno commented Jul 13, 2024

Omg 🤯

@Kaiserdragon2
Copy link
Collaborator

Wow that is an huge amount of icons

@wwwwwwari
Copy link
Contributor Author

Just want to try to hit 10k before my semester starts 😂

@Donnnno
Copy link
Collaborator

Donnnno commented Jul 15, 2024

Found some errors! (and am fixing then)

Almost 1px 😅
image

Also, I found some errors in your rounded square. it seems to be a bit off:

image
image

Circles
image

@wwwwwwari
Copy link
Contributor Author

I think there's really something wrong with my InkScape settings lol. I can look into it myself tomorrow (and maybe submit unoptimized SVGs straight from InkScape?)

I exported all of them under the same settings so all submitted SVGs probably have incorrect values.

Co-Authored-By: Wari <89649458+wwwwwwari@users.noreply.github.com>
@Donnnno
Copy link
Collaborator

Donnnno commented Jul 15, 2024

That's really weird, there must be some kind of bug then? It might be worth letting the Inkscape team know if there's an issue with the export settings.

@Donnnno Donnnno merged commit d18e6f4 into Arcticons-Team:main Jul 15, 2024
1 check passed
@Donnnno
Copy link
Collaborator

Donnnno commented Jul 15, 2024

Nevertheless, amazing work. Really! I can't thank you enough for doing such incredible work! :)

@wwwwwwari
Copy link
Contributor Author

Thanks for going through all of them too. That's gotta be tiring 🫠

@Donnnno
Copy link
Collaborator

Donnnno commented Jul 15, 2024

I got a script that imports all icons into Illustrator with their artboard names, so that makes it easier, haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants