Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HK: add race bool to slot data #3971

Merged
merged 5 commits into from
Sep 21, 2024
Merged

HK: add race bool to slot data #3971

merged 5 commits into from
Sep 21, 2024

Conversation

qwint
Copy link
Collaborator

@qwint qwint commented Sep 20, 2024

What is this fixing or adding?

add race bool to slot data

How was this tested?

wasn't

If this makes graphical changes, please attach screenshots.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Sep 20, 2024
Exempt-Medic
Exempt-Medic approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, matches the formatting elsewhere and properly adds to slot_data (printed it out to check)

@Exempt-Medic Exempt-Medic added the is: enhancement Issues requesting new features or pull requests implementing new features. label Sep 20, 2024
@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Sep 20, 2024
@ScipioWright ScipioWright added waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. and removed waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. labels Sep 20, 2024
ScipioWright
ScipioWright approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't test but half of it is copied from Tunic so

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Sep 20, 2024
Berserker66
Berserker66 approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@Berserker66 Berserker66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the setting should mention that it gets overruled by race mode, but implementation looks fine to me.

@Berserker66 Berserker66 merged commit 41ddb96 into ArchipelagoMW:main Sep 21, 2024
18 checks passed
@qwint qwint deleted the hk_race branch September 23, 2024 00:15
@BadMagic100 BadMagic100 mentioned this pull request Sep 23, 2024
Merged
AustinSumigray pushed a commit to AustinSumigray/Archipelago that referenced this pull request Jan 4, 2025
@qwint @AustinSumigray
HK: add race bool to slot data (ArchipelagoMW#3971)
7eba27e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Berserker66 Berserker66 Berserker66 approved these changes

@ScipioWright ScipioWright ScipioWright approved these changes

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qwint @Berserker66 @ScipioWright @Exempt-Medic