Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: Removing #archipelago-dev from places #3876

Merged
merged 9 commits into from
Sep 5, 2024

Conversation

ReverM
Copy link
Contributor

@ReverM ReverM commented Sep 4, 2024

Please format your title with what portion of the project this pull request is
targeting and what it's changing.

DOCS: Changing #archipelago-dev to #ap-world-dev

What is this fixing or adding?

See above

How was this tested?

I read

If this makes graphical changes, please attach screenshots.

@github-actions github-actions bot added is: documentation Improvements or additions to documentation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Sep 4, 2024
@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Sep 4, 2024
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk if it should be ap-world-dev or ap-core-dev, but the core review can figure that out

@github-actions github-actions bot added the affects: webhost Issues/PRs that touch webhost and may need additional validation. label Sep 4, 2024
@ReverM ReverM changed the title ap-world-dev-new-name DOCS: Removing #archipelago-dev from places Sep 4, 2024
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. These are the only instances and they are changed to the proper of the two channels

@ReverM
Copy link
Contributor Author

ReverM commented Sep 4, 2024

idk if it should be ap-world-dev or ap-core-dev, but the core review can figure that out

Yeah fair. I think it makes more sense in ap-world-dev tho?

Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -35,7 +35,7 @@ When a world is unmaintained, the [core maintainers](https://github.com/orgs/Arc
can vote for a new maintainer if there is a candidate.
For a vote to pass, the majority of participating core maintainers must vote in the affirmative.
The time limit is 1 week, but can end early if the majority is reached earlier.
Voting shall be conducted on Discord in #archipelago-dev.
Voting shall be conducted on Discord in #ap-world-dev.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this should be core instead 🤔 opinions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a strong one

I do see your point about it being a core thing so it should be in ⁠ap-core-dev

But then other other hand, it's something where the discussion would probably start in ⁠ap-world-dev, so we'd have to "move over" at some point for the poll I guess?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, I'd be fine with either, however I think previous communications of that nature were done in a thread that was not visible to the public?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's also true haha

Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna make the call. Since this is about inclusion of a world in core rather than about world development, I believe -core is the right place and the archived previous threads are also there.

ReverM and others added 2 commits September 5, 2024 15:30
Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
@ReverM
Copy link
Contributor Author

ReverM commented Sep 5, 2024

Changed have been made

Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@black-sliver black-sliver merged commit f9fc694 into ArchipelagoMW:main Sep 5, 2024
12 checks passed
AustinSumigray pushed a commit to AustinSumigray/Archipelago that referenced this pull request Jan 4, 2025
* Cleaning up (ArchipelagoMW#4)

Cleanup

* Changed channel name

* Changed channel name

* Update docs/world maintainer.md

* Update docs/world maintainer.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: webhost Issues/PRs that touch webhost and may need additional validation. is: documentation Improvements or additions to documentation. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants