-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS: Removing #archipelago-dev from places #3876
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk if it should be ap-world-dev or ap-core-dev, but the core review can figure that out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. These are the only instances and they are changed to the proper of the two channels
Yeah fair. I think it makes more sense in ap-world-dev tho? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
docs/world maintainer.md
Outdated
@@ -35,7 +35,7 @@ When a world is unmaintained, the [core maintainers](https://github.com/orgs/Arc | |||
can vote for a new maintainer if there is a candidate. | |||
For a vote to pass, the majority of participating core maintainers must vote in the affirmative. | |||
The time limit is 1 week, but can end early if the majority is reached earlier. | |||
Voting shall be conducted on Discord in #archipelago-dev. | |||
Voting shall be conducted on Discord in #ap-world-dev. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this should be core instead 🤔 opinions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a strong one
I do see your point about it being a core thing so it should be in ap-core-dev
But then other other hand, it's something where the discussion would probably start in ap-world-dev, so we'd have to "move over" at some point for the poll I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea, I'd be fine with either, however I think previous communications of that nature were done in a thread that was not visible to the public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's also true haha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm gonna make the call. Since this is about inclusion of a world in core rather than about world development, I believe -core is the right place and the archived previous threads are also there.
Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
Changed have been made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Cleaning up (ArchipelagoMW#4) Cleanup * Changed channel name * Changed channel name * Update docs/world maintainer.md * Update docs/world maintainer.md
Please format your title with what portion of the project this pull request is
targeting and what it's changing.
DOCS: Changing #archipelago-dev to #ap-world-dev
What is this fixing or adding?
See above
How was this tested?
I read
If this makes graphical changes, please attach screenshots.