sc2: Fixed sc2 client's /received command breaking after PR 1933 merged #3497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exempt-Medic
added
is: bug/fix
github-actions
bot
added
the
waiting-on: peer-review
Ziktofel
approved these changes
Jun 9, 2024
Ziktofel
removed
the
waiting-on: world-maintainer
NewSoupVi
approved these changes
Jun 9, 2024
agilbert1412
pushed a commit
to agilbert1412/Archipelago
that referenced
this pull request
Jun 13, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
AustinSumigray
pushed a commit
to AustinSumigray/Archipelago
that referenced
this pull request
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
After PR #1933 merged, it seems to have broken the custom
/receivedcommand in the Starcraft 2 client. The root of the issue was that the item printout just used the default player ID of 0, but that's not considered an actual player by the decoder and it needs that information to translate a local item ID to an actual item name.How was this tested?
Ran
/receivedfrom the starcraft 2 client with a start inventory and a few items collected from doing a mission. It now prints correctly and no longer returns a stack trace. Didn't test this with items that were collected by slots playing a different game, not sure if that's a potential issue.If this makes graphical changes, please attach screenshots.
None