-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HK: add grub hunt goal #3203
Merged
Merged
HK: add grub hunt goal #3203
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
68dd908
makes grub hunt goal option that calculates the total available grubs…
qwint 1ebf094
update slot data name for grub count
qwint e0d3ef7
add option to set number needed for grub hub
qwint 06096aa
updates to grub hunt goal based on review
qwint 5fb3952
copy/paste fix
qwint 116ee3f
account for 'any' goal and fix overriding non-grub goals
qwint 2649700
making sure godhome is in logic for any and removing redundancy on co…
qwint b60800b
fix typing
qwint 6297fed
i hate typing
qwint be2a812
move to stage_pre_fill
qwint fd574e4
modify "any" goal so all goals are in logic under minimal settings
qwint d981f0b
rewrite grub counting to create lookups for grubs and groups that can…
qwint 7e7b6c1
use generator instead of list comprehension
qwint 18d5a29
fix whitespace merging wrong
qwint a318719
minor code cleanup
qwint File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should populate slot data if the goal is Any as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if grub hunt is a valid 'any' goal, how do you want to handle the completion condition?
leave as-is but send the count in slot data so we know when to send goal complete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I would do it that way just so that minimal + any doesn't accidentally force something stupid (we'll leave that for minimal + random goal)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually maybe a better approach for any goal would be to ensure every goal is completable in logic so that even on minimal the player would have any choice of goal