LTTP: fix some hashed string comparisons

[alwaysintreble]

What is this fixing or adding?

an option can't be compared to strings in a set due to hashing

How was this tested?

Unit tests and a few generations with debugging

If this makes graphical changes, please attach screenshots.

[Ixrec]

Code LGTM, but I don't know LttP logic enough to meaningfully test this.

IMO it's worth stating explicitly that this does change behavior, but in a way that hopefully fixes undiscovered bugs. In particular, option in stringset always returns False, so some of this code is dead on main but brought back to life by this PR; so we want to ask the world maintainer how safe it is to revive this dead code and how well-tested these cases are. (I see their review's already been requested)

[Ixrec]

>       if logic.current_key in {'overworld_glitches', 'hybrid_major_glitches', 'no_logic'} and world.glitch_boots[player]:
E       AttributeError: 'str' object has no attribute 'current_key'

Hm

logic = world.glitches_required[player]

That option is a Choice. Is it possible current_key depends on the new options API somehow? I don't know how a Choice could end up lacking these properties only inside LttP.

[alwaysintreble]

>       if logic.current_key in {'overworld_glitches', 'hybrid_major_glitches', 'no_logic'} and world.glitch_boots[player]:
E       AttributeError: 'str' object has no attribute 'current_key'

Hm

logic = world.glitches_required[player]

That option is a Choice. Is it possible current_key depends on the new options API somehow? I don't know how a Choice could end up lacking these properties only inside LttP.

the unit tests were assigning a string instead of an option class to the option.