FF1: Fix items getting resent on disconnect/connect #2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilbert1412
added
the
waiting-on: peer-review
ScipioWright
added
the
is: bug/fix
benny-dreamly
approved these changes
Feb 16, 2024
hatkirby
approved these changes
Mar 5, 2024
nicholassaylor
approved these changes
Mar 5, 2024
|
I have not tested this myself, but it's a one-liner that does what the PR says it should do. |
PoryGone
approved these changes
Mar 11, 2024
PoryGone
added
waiting-on: core-review
Berserker66
approved these changes
Mar 11, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
When the client would disconnect during gameplay, the internal count of items would get reset to 0; upon reconnecting to the client, AP would resend every items received creating duplicate of all items.
How was this tested?
Beta tested over the course of 2 weeks by 3 players without any issue.