WebHost: Restore game name in description, don't hardcode archipelago.gg #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArchipelagoMW#1820 added the game name to template export, but when ArchipelagoMW#2143 began overriding the description in Javascript to name the preset it removed the game name. Also while I was here I figured we might as well not hardcode https://archipelago.gg, since it can be useful to know if a YAML was generated by some other Web Host (for example http://archipelago.gg:24242 if coming from the beta site)
|
i'm pretty hesitant on the secondary change as it seems very easy for someone to accidentally release their own or someone else's IP address |
ScipioWright
added
the
affects: webhost
|
This change will eventually be overwritten by #2614. Most of the JS has been removed, and that description is now handled by Python when generating the YAML file as the result of a POST. I will be happy to review this again if you point it at my branch, option-groups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
#1820 added the game name to template export, but when #2143 began overriding the description in Javascript to name the preset it removed the game name.
Also while I was here I figured we might as well not hardcode https://archipelago.gg, since it can be useful to know if a YAML was generated by some other web host (for example http://archipelago.gg:24242 if coming from the beta site)
How was this tested?
Ran this on a local webhost and generated a YAML and saw
Generated by http://localhost for Factorio with the default preset.. Changed the port, sawGenerated by http://localhost:81 for Factorio with the default preset.. Pointed my nginx proxy which has a HTTPS cert on it, sawGenerated by https://<domain> for Factorio with the default preset.